Unverified Commit 704dcb3e authored by Ryan Holmes's avatar Ryan Holmes Committed by GitHub

Move assignment of `new_coverpath`

With the assignment originally being within the try, if the try failed, the exception wouldn't have access to the value
parent 1a1d105f
......@@ -223,7 +223,6 @@ def delete_book(book_id, book_format):
getattr(book, cc_string).remove(del_cc)
log.debug('remove ' + str(c.id))
calibre_db.session.delete(del_cc)
calibre_db.session.commit()
else:
modify_database_object([u''], getattr(book, cc_string), db.cc_classes[c.id],
calibre_db.session, 'custom')
......@@ -833,8 +832,8 @@ def upload():
# move cover to final directory, including book id
if has_cover:
new_coverpath = os.path.join(config.config_calibre_dir, db_book.path, "cover.jpg")
try:
new_coverpath = os.path.join(config.config_calibre_dir, db_book.path, "cover.jpg")
copyfile(meta.cover, new_coverpath)
os.unlink(meta.cover)
except OSError as e:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment