Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Contribute to GitLab
Sign in / Register
Toggle navigation
D
douban-api-proxy
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
captainwong
douban-api-proxy
Commits
d5d0ad50
Commit
d5d0ad50
authored
Jul 22, 2021
by
Ileana Maricel Barrionuevo
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixed security issue: a user could edit others' shelves.
parent
20fa9f55
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
2 additions
and
0 deletions
+2
-0
shelf.py
cps/shelf.py
+2
-0
No files found.
cps/shelf.py
View file @
d5d0ad50
...
@@ -235,6 +235,8 @@ def create_shelf():
...
@@ -235,6 +235,8 @@ def create_shelf():
@
login_required
@
login_required
def
edit_shelf
(
shelf_id
):
def
edit_shelf
(
shelf_id
):
shelf
=
ub
.
session
.
query
(
ub
.
Shelf
)
.
filter
(
ub
.
Shelf
.
id
==
shelf_id
)
.
first
()
shelf
=
ub
.
session
.
query
(
ub
.
Shelf
)
.
filter
(
ub
.
Shelf
.
id
==
shelf_id
)
.
first
()
if
not
shelf
.
user_id
==
int
(
current_user
.
id
):
return
"Sorry you are not allowed to edit this shelf"
,
403
return
create_edit_shelf
(
shelf
,
title
=
_
(
u"Edit a shelf"
),
page
=
"shelfedit"
,
shelf_id
=
shelf_id
)
return
create_edit_shelf
(
shelf
,
title
=
_
(
u"Edit a shelf"
),
page
=
"shelfedit"
,
shelf_id
=
shelf_id
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment