Commit 9c70a359 authored by Nikias Bassen's avatar Nikias Bassen

xplist: Really fix OOB read when parsing DOCTYPE

parent 322b2c9d
......@@ -876,7 +876,7 @@ static void node_from_xml(parse_ctx ctx, plist_t *plist, uint32_t depth)
}
if (embedded_dtd) {
find_str(ctx, "]>", 2, 1);
if (ctx->pos >= ctx->end || strncmp(ctx->pos, "]>", 2)) {
if (ctx->pos > ctx->end-2 || strncmp(ctx->pos, "]>", 2)) {
PLIST_XML_ERR("Couldn't find end of DOCTYPE\n");
ctx->err++;
goto err_out;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment