Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Contribute to GitLab
Sign in / Register
Toggle navigation
L
libplist
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
1
Issues
1
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
pwn
libplist
Commits
fa4d1ce8
Commit
fa4d1ce8
authored
Feb 07, 2017
by
Nikias Bassen
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
xplist: Also fix OOB read in find_char() and find_str() functions
parent
e4dc36f1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
8 additions
and
0 deletions
+8
-0
xplist.c
src/xplist.c
+8
-0
No files found.
src/xplist.c
View file @
fa4d1ce8
...
...
@@ -435,6 +435,10 @@ static void find_char(parse_ctx ctx, char c, int skip_quotes)
if
(
skip_quotes
&&
(
c
!=
'"'
)
&&
(
*
(
ctx
->
pos
)
==
'"'
))
{
ctx
->
pos
++
;
find_char
(
ctx
,
'"'
,
0
);
if
(
ctx
->
pos
>=
ctx
->
end
)
{
PLIST_XML_ERR
(
"EOF while looking for matching double quote
\n
"
);
return
;
}
if
(
*
(
ctx
->
pos
)
!=
'"'
)
{
PLIST_XML_ERR
(
"Unmatched double quote
\n
"
);
return
;
...
...
@@ -453,6 +457,10 @@ static void find_str(parse_ctx ctx, const char *str, size_t len, int skip_quotes
if
(
skip_quotes
&&
(
*
(
ctx
->
pos
)
==
'"'
))
{
ctx
->
pos
++
;
find_char
(
ctx
,
'"'
,
0
);
if
(
ctx
->
pos
>=
ctx
->
end
)
{
PLIST_XML_ERR
(
"EOF while looking for matching double quote
\n
"
);
return
;
}
if
(
*
(
ctx
->
pos
)
!=
'"'
)
{
PLIST_XML_ERR
(
"Unmatched double quote
\n
"
);
return
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment