- 01 Jan, 2017 4 commits
-
-
Nikias Bassen authored
-
Nikias Bassen authored
-
Nikias Bassen authored
'</key >' is a perfectly valid closing tag and so is '</key >' (note the newline). This commit will make the parser skip any encountered whitespace before checking for the closing '>'.
-
Nikias Bassen authored
-
- 21 Dec, 2016 3 commits
-
-
Nikias Bassen authored
-
Nikias Bassen authored
-
Nikias Bassen authored
-
- 14 Dec, 2016 3 commits
-
-
Nikias Bassen authored
-
Nikias Bassen authored
-
Nikias Bassen authored
-
- 28 Nov, 2016 1 commit
-
-
Nikias Bassen authored
The context position counter was increased after encountering a closing node, e.g. '</dict>' or after a closing '</key>' node. When a node followed it directly without any whitespace inbetween, e.g. </dict><key>, parsing would fail since the parser would look at 'key>' instead of '<key>' for the next node to be parsed.
-
- 13 Nov, 2016 4 commits
-
-
Nikias Bassen authored
-
Nikias Bassen authored
-
Nikias Bassen authored
-
Nikias Bassen authored
-
- 31 Oct, 2016 3 commits
-
-
Filippo Bigarella authored
In case parsing inside `node_from_xml` called from line 842 fails, `data` gets freed by the call to `plist_free` at line 899, since `subnode` is actually created by making it point to `data` at line 684. This commit prevents this situation by bailing out whenever parsing in a deeper level of structured nodes fails.
-
Filippo Bigarella authored
If `ctx->pos - p - 1` is greater than `taglen`, we end up writing outside the buffer pointed to by `tag`. This commit fixes it by checking the bounds of the heap buffer before writing.
-
Filippo Bigarella authored
-
- 22 Oct, 2016 1 commit
-
-
Nikias Bassen authored
-
- 19 Sep, 2016 1 commit
-
-
Nikias Bassen authored
The main benefit of this is to allow date/time values outside of the 32bit time_t range which is very important on 32bit platforms. But there are also some other issues that will be fixed with this, for example on macOS, mktime() will not work for dates < 1902 despite time_t being 64bit. In the same run this commit will also use a reentrant version of gmtime64_r that should help in multithreaded scenarios. Original code taken from: https://github.com/evalEmpire/y2038
-
- 18 Sep, 2016 1 commit
-
-
Nikias Bassen authored
This removes the timeval union member from the plist_data_t structure. Since struct timeval is 2x64bit on 64bit platforms this member unnecessarily grew the union size to 16 bytes while a size of 8 bytes is sufficient. Also, on 32bit platforms struct timeval is only 2x32bit of size, limiting the range of possible time values. In addition the binary property list format also stores PLIST_DATE nodes as double.
-
- 29 Jun, 2016 1 commit
-
-
Nikias Bassen authored
In node_to_xml nodes of type PLIST_UID are temporarily converted to a PLIST_DICT for an appropriate XML output. Therefore a PLIST_KEY and a PLIST_UINT node is created and inserted into the PLIST_DICT node. Upon completion, the child nodes of the PLIST_DICT node are detached from the original node and freed, however the data of the child nodes - the key string and the uint value - are not. This commit fixes it.
-
- 20 Apr, 2016 1 commit
-
-
Frederik Carlier authored
-
- 13 Nov, 2015 1 commit
-
-
Nikias Bassen authored
-
- 23 Jan, 2015 3 commits
-
-
Martin Szulecki authored
This is actually considered bad practice. However, it appears this memory leak is otherwise not possible to fix due to a design flaw in how libxml2 handles the lifecycle of it's XML parser. We'll let the community test this in production now and decide. In our tests this change had no drawbacks except fixing the last known memory leak in libplist.
-
Martin Szulecki authored
-
Martin Szulecki authored
By using a specifically crafted XML file an attacker could use plistutil to issue a GET request to an arbitrary URL or disclose a local file. The crafted XML file would be using a custom DTD with an external entity reference pointing to the file. Practical abuse is limited but let's still fix it nevertheless. Related to CVE-2013-0339 for libxml2 and CWE-827. Reported by Loïc Bénis from calypt.com. Thanks!
-
- 03 Oct, 2014 1 commit
-
-
Nikias Bassen authored
-
- 25 Aug, 2014 1 commit
-
-
Aaron Burghardt authored
-
- 27 May, 2014 1 commit
-
-
Martin Szulecki authored
-
- 23 May, 2014 1 commit
-
-
Nikias Bassen authored
-
- 22 May, 2014 2 commits
-
-
Nikias Bassen authored
-
Nikias Bassen authored
-
- 21 May, 2014 1 commit
-
-
Nikias Bassen authored
-
- 18 May, 2014 1 commit
-
-
Nikias Bassen authored
-
- 01 Apr, 2014 1 commit
-
-
Nikias Bassen authored
-
- 13 Dec, 2013 3 commits
-
-
Nikias Bassen authored
-
Nikias Bassen authored
-
Nikias Bassen authored
-
- 06 Mar, 2013 1 commit
-
-
Nikias Bassen authored
-