1. 29 Oct, 2013 1 commit
  2. 12 Feb, 2011 1 commit
    • Christophe Fergeau's avatar
      Fix Dictionary copy constructor · be225ca1
      Christophe Fergeau authored
      While iterating over all the keys stored in the source Dictionary
      to copy them to create the copied Dictonary, the name of the key
      being copied was only set to a non-NULL value for the first key
      we copy. This was then leading to an assertion when trying to
      create a std::string from a NULL pointer. Simple test-case:
      
      int main()
      {
      	PList::Dictionary a;
      	PList::String b("Hello");
      	PList::String c("Hi!");
      	PList::Dictionary d;
      
      	a.Insert("Key", &b);
      	a.Insert("Another Key", &c);
      	std::cout << a.ToXml() << std::endl;
      
      	d.Insert("dictionary", &a); //CRAAAAAAAAASH!
      	std::cout << d.ToXml() << std::endl;
      	return 0;
      }
      /* Output:
      <?xml version="1.0" encoding="UTF-8"?>
      <!DOCTYPE plist PUBLIC "-//Apple Computer//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
      <plist version="1.0">
      <dict>
      	<key>Key</key>
      	<string>Hello</string>
      	<key>Another Key</key>
      	<string>Hi!</string>
      </dict>
      </plist>
      
      terminate called after throwing an instance of 'std::logic_error'
        what():  basic_string::_S_construct NULL not valid
      */
      Signed-off-by: 's avatarMartin Szulecki <opensuse@sukimashita.com>
      be225ca1
  3. 28 Nov, 2009 1 commit
  4. 11 Nov, 2009 1 commit
  5. 10 Nov, 2009 2 commits
  6. 04 Nov, 2009 1 commit
  7. 28 Oct, 2009 2 commits
  8. 26 Oct, 2009 1 commit
  9. 18 Oct, 2009 1 commit
  10. 16 Oct, 2009 2 commits
  11. 15 Oct, 2009 1 commit
  12. 13 Oct, 2009 1 commit