- 06 Feb, 2017 1 commit
-
-
Nikias Bassen authored
-
- 05 Feb, 2017 5 commits
-
-
Nikias Bassen authored
-
Nikias Bassen authored
This commit adds proper debug/error messages being printed if the binary plist parser encounters anything abnormal. To enable debug logging, libplist must be configured with --enable-debug, and the environment variable PLIST_BIN_DEBUG must be set to "1".
-
Nikias Bassen authored
-
Nikias Bassen authored
-
Nikias Bassen authored
-
- 04 Feb, 2017 1 commit
-
-
Nikias Bassen authored
Issue #92 pointed out an problem with (invalid) bplist files which have exactly one structured node whose subnode reference itself. The recursion check used a fixed size array with the size of the total number of objects. In this case the number of objects is 1 but the recursion check code wanted to set the node_index for the level 1 which leads to an OOB write on the heap. This commit fixes/improves two things: 1) Prevent OOB write by using a dynamic data storage for the used node indexes (plist_t of type PLIST_ARRAY) 2) Reduces the memory usage of large binary plists, because not the total number of nodes in the binary plist, but the number of recursion levels is important for the recursion check.
-
- 03 Feb, 2017 2 commits
-
-
Nikias Bassen authored
As reported in #91, the code that will read the big endian integer value of variable size did not check if the actual number of bytes is still withing the range of the actual plist data. This commit fixes the issue with proper bounds checking.
-
Nikias Bassen authored
-
- 01 Feb, 2017 2 commits
-
-
Nikias Bassen authored
-
Nikias Bassen authored
The sizes where effectively parsed by calling parse_uint_node() which allocates a node_t (along with plist_data_t) that is immediately freed after retrieving the integer value it holds. This commit changes the code to directly operate on the binary stream to 'just' read the size instead, reducing the memory footprint further.
-
- 28 Jan, 2017 8 commits
-
-
Nikias Bassen authored
-
Nikias Bassen authored
-
Nikias Bassen authored
-
Nikias Bassen authored
-
Nikias Bassen authored
-
Nikias Bassen authored
-
Nikias Bassen authored
-
Nikias Bassen authored
-
- 25 Jan, 2017 2 commits
-
-
Nikias Bassen authored
Apple only allows 32 bit unsigned values for UID nodes. Also the encoding of the length is different from the encoding used for other node types. The nibble used to mark the size is 1 less than the actual size of the integer value data, so 0 means 1 byte length 1 means 2 bytes length, etc.
-
Nikias Bassen authored
-
- 19 Jan, 2017 4 commits
-
-
Nikias Bassen authored
-
Nikias Bassen authored
-
Nikias Bassen authored
-
Wang Junjie authored
-
- 18 Jan, 2017 1 commit
-
-
Nikias Bassen authored
The uint24_from_be function used memcpy and a call to byte_convert. Instead the macro now shifts the data appropriately with a new beNtoh macro that eventually uses be64toh. This commit also fixes the problem where binary plist data with other non-power-of-2 sizes (like 5,6, or 7) where not handled correctly, and actually supports sizes larger than 8 bytes though only the last 8 bytes are actually converted (nobody will come up with such a large plist anyway).
-
- 16 Jan, 2017 1 commit
-
-
Nikias Bassen authored
As reported in #86, the binary plist parser would force the type of the key node to be of type PLIST_KEY while the node might be of a different i.e. non-string type. A following plist_free() might then call free() on an invalid pointer; e.g. if the node is of type integer, its value would be considered a pointer, and free() would cause an error. We prevent this issue by disallowing non-string key nodes during parsing.
-
- 18 Nov, 2016 2 commits
-
-
Nikias Bassen authored
-
Nikias Bassen authored
-
- 13 Nov, 2016 1 commit
-
-
Nikias Bassen authored
-
- 10 Nov, 2016 4 commits
-
-
Filippo Bigarella authored
If the allocation fails, a lot of bad things can happen so we check the result and return accordingly. We also check that the multiplication used to calculate the buffer size doesn't overflow. Otherwise this could lead to an allocation of a very small buffer compared to what we need, ultimately leading to arbitrary writes later on.
-
Filippo Bigarella authored
offset_table_index is read from the file, so we have full control over it. This means we can point offset_table essentially anywhere we want, which can lead to an out-of-bounds read when it will be used later on.
-
Filippo Bigarella authored
-
Filippo Bigarella authored
-
- 09 Nov, 2016 1 commit
-
-
Filippo Bigarella authored
-
- 22 Oct, 2016 1 commit
-
-
Nikias Bassen authored
-
- 18 Sep, 2016 1 commit
-
-
Nikias Bassen authored
This removes the timeval union member from the plist_data_t structure. Since struct timeval is 2x64bit on 64bit platforms this member unnecessarily grew the union size to 16 bytes while a size of 8 bytes is sufficient. Also, on 32bit platforms struct timeval is only 2x32bit of size, limiting the range of possible time values. In addition the binary property list format also stores PLIST_DATE nodes as double.
-
- 12 May, 2016 1 commit
-
-
Nikias Bassen authored
Using a better hashing algorithm and a larger hash table the conversion is A LOT faster when processing large plists. Thanks to Xiao Deng for reporting this issue and suggesting a fix.
-
- 05 Feb, 2015 1 commit
-
-
Nikias Bassen authored
-
- 31 Jan, 2015 1 commit
-
-
Nikias Bassen authored
When parsing binary plists with BPLIST_DICT or BPLIST_ARRAY nodes that are referenced multiple times in a particular file, a buffer was allocated that was not used, and also not freed, thus causing memory leaks.
-