- 28 Mar, 2017 1 commit
-
-
Nikias Bassen authored
-
- 26 Mar, 2017 1 commit
-
-
Nikias Bassen authored
Because on 32-bit platforms 32-bit pointers and 64-bit sizes have been used for the sanity checks of the offset table and object references, the range checks would fail in certain interger-overflowish situations, causing heap buffer overflows or other unwanted behavior. Fixed by wideing the operands in question to 64-bit.
-
- 18 Mar, 2017 1 commit
-
-
Nikias Bassen authored
-
- 18 Feb, 2017 1 commit
-
-
Nikias Bassen authored
Credit to OSS-Fuzz
-
- 15 Feb, 2017 1 commit
-
-
Nikias Bassen authored
Instead of letting the buffer grow by just the amount of bytes currently transformed to base64 - which is basically line by line - we now calculate the size of the output blob in advance and grow the buffer accordingly. This will reduce the amount of reallocs to just one, which is especially important for large data blobs. While this is a general improvement for all platforms, it is on platforms like Windows where realloc() can be REALLY slow; converting a 20mb blob to XML can easily take up to a minute (due to the several hundred thousand calls to realloc()). With this commit, it will be fast again.
-
- 10 Feb, 2017 2 commits
-
-
Nikias Bassen authored
Passing a size of 0xFFFFFFFFFFFFFFFF to parse_string_node() might result in a memcpy with a size of -1, leading to undefined behavior. This commit makes sure that the actual node data (which depends on the size) is in the range start_of_object..start_of_object+size. Credit to OSS-Fuzz
-
Nikias Bassen authored
Credit to OSS-Fuzz
-
- 09 Feb, 2017 3 commits
-
-
Nikias Bassen authored
Credit to OSS-Fuzz
-
Nikias Bassen authored
Credit to OSS-Fuzz
-
Nikias Bassen authored
Credit to OSS-Fuzz
-
- 08 Feb, 2017 1 commit
-
-
Nikias Bassen authored
-
- 07 Feb, 2017 15 commits
-
-
Nikias Bassen authored
Credit to Wang Junjie <zhunkibatu@gmail.com> (#90) Credit to OSS-Fuzz
-
Nikias Bassen authored
-
Nikias Bassen authored
Credit to OSS-Fuzz
-
Nikias Bassen authored
Credit to OSS-Fuzz
-
Nikias Bassen authored
Credit to Wang Junjie <zhunkibatu@gmail.com> (#93)
-
Nikias Bassen authored
-
Nikias Bassen authored
-
Nikias Bassen authored
-
Nikias Bassen authored
-
Nikias Bassen authored
-
Nikias Bassen authored
-
Nikias Bassen authored
-
Nikias Bassen authored
-
Nikias Bassen authored
-
Nikias Bassen authored
-
- 06 Feb, 2017 3 commits
-
-
Nikias Bassen authored
-
Nikias Bassen authored
-
Nikias Bassen authored
-
- 05 Feb, 2017 5 commits
-
-
Nikias Bassen authored
-
Nikias Bassen authored
This commit adds proper debug/error messages being printed if the binary plist parser encounters anything abnormal. To enable debug logging, libplist must be configured with --enable-debug, and the environment variable PLIST_BIN_DEBUG must be set to "1".
-
Nikias Bassen authored
-
Nikias Bassen authored
-
Nikias Bassen authored
-
- 04 Feb, 2017 1 commit
-
-
Nikias Bassen authored
Issue #92 pointed out an problem with (invalid) bplist files which have exactly one structured node whose subnode reference itself. The recursion check used a fixed size array with the size of the total number of objects. In this case the number of objects is 1 but the recursion check code wanted to set the node_index for the level 1 which leads to an OOB write on the heap. This commit fixes/improves two things: 1) Prevent OOB write by using a dynamic data storage for the used node indexes (plist_t of type PLIST_ARRAY) 2) Reduces the memory usage of large binary plists, because not the total number of nodes in the binary plist, but the number of recursion levels is important for the recursion check.
-
- 03 Feb, 2017 2 commits
-
-
Nikias Bassen authored
As reported in #91, the code that will read the big endian integer value of variable size did not check if the actual number of bytes is still withing the range of the actual plist data. This commit fixes the issue with proper bounds checking.
-
Nikias Bassen authored
-
- 01 Feb, 2017 3 commits
-
-
Nikias Bassen authored
-
Nikias Bassen authored
-
Nikias Bassen authored
The sizes where effectively parsed by calling parse_uint_node() which allocates a node_t (along with plist_data_t) that is immediately freed after retrieving the integer value it holds. This commit changes the code to directly operate on the binary stream to 'just' read the size instead, reducing the memory footprint further.
-